Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13127]Breadcrumb event logs #5430

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cyprain-okeke
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13127

📔 Objective

GIVEN: ALL the following

the user is in the admin console, viewing a Free or Families org

the user has the “owner” role for this org

THEN:

Show “Event logs” in the left hand navigation

GIVEN: ALL the following

the user is in the admin console, viewing a Free or Families org

the user has the “owner” role for this org

the user is viewing event logs

THEN:

implement the design shown in figma. Here are example event logs to show

I think it would be FUN to randomize the order of this list, but it that is extra work, then it can be kept in this order.

I think the timestamps just need to be random times from the past 24 hours.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke requested a review from a team February 20, 2025 09:31
Copy link
Contributor

github-actions bot commented Feb 20, 2025

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found Info
Breadcrumbing for business features pm-12276-breadcrumbing-for-business-features

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Logo
Checkmarx One – Scan Summary & Detailsaa595a85-34ec-4c61-b5fc-24a7b225367f

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
detailsMethod Post at line 143 of /src/Api/Controllers/CollectionsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
MEDIUM CSRF /src/Identity/Controllers/AccountsController.cs: 119
detailsMethod PostRegister at line 119 of /src/Identity/Controllers/AccountsController.cs gets a parameter from a user request from PostRegister. This par...
Attack Vector
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 308
detailsMethod PushAuthRequestAsync at line 308 of /src/Core/NotificationHub/NotificationHubPushNotificationService.cs sends user information outside the a...
Attack Vector
Fixed Issues (41)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 70
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 104
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 94
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 221
MEDIUM Privacy_Violation /src/Core/Auth/Services/Implementations/AuthRequestService.cs: 230
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.46%. Comparing base (06c96a9) to head (c3f8bec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5430   +/-   ##
=======================================
  Coverage   44.46%   44.46%           
=======================================
  Files        1511     1511           
  Lines       70266    70266           
  Branches     6342     6342           
=======================================
  Hits        31245    31245           
  Misses      37679    37679           
  Partials     1342     1342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants