Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

494 fix linting errors and integrate husky for pre commit formatting #531

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

494 fix linting errors and integrate husky for pre commit formatting #531

wants to merge 5 commits into from

Conversation

MandeepPaul
Copy link
Contributor

@MandeepPaul MandeepPaul commented Feb 1, 2025 •
edited
Loading

Describe your changes

  • Removed unused variables
  • Added missing prop validations
  • Setup husky to format stagged files before every commit

Issue number

#494

Please ensure all items are checked off before requesting a review:

  • I deployed the code locally.
  • I have performed a self-review of my code.
  • I have included the issue # in the PR.
  • I have labelled the PR correctly.
  • The issue I am working on is assigned to me.
  • I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • I made sure font sizes, color choices etc are all referenced from the theme.
  • My PR is granular and targeted to one specific feature.
  • I took a screenshot or a video and attached to this PR if there is a UI change.

@MandeepPaul MandeepPaul requested a review from erenfn February 2, 2025 05:59
@erenfn erenfn requested a review from swoopertr February 4, 2025 17:39
erenfn
erenfn approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@erenfn erenfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But, before merging let's wait for another approval since so many files have changed

@erenfn erenfn requested a review from DeboraSerra February 5, 2025 21:56
swoopertr
swoopertr approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@swoopertr swoopertr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unending file reviews

@erenfn
Copy link
Collaborator

erenfn commented Feb 18, 2025

After resolving conflicts can you update the PR?

@MandeepPaul
Copy link
Contributor Author

After resolving conflicts can you update the PR?

Sure! I will fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swoopertr swoopertr swoopertr approved these changes

@erenfn erenfn erenfn approved these changes

@DeboraSerra DeboraSerra Awaiting requested review from DeboraSerra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MandeepPaul @erenfn @swoopertr