-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name files names and docs from async #28
Conversation
Signed-off-by: Matheus Horstmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review from typot
docs/source/api_reference.rst
Outdated
@@ -3,6 +3,6 @@ API Reference | |||
|
|||
.. toctree:: | |||
|
|||
async | |||
asyncclient |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
docs/source/async.rst
Outdated
@@ -1,5 +1,5 @@ | |||
Async module | |||
------------ | |||
|
|||
.. automodule:: deezer.async | |||
.. automodule:: deezer.asyncclient |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
docs/source/async.rst
Outdated
@@ -1,5 +1,5 @@ | |||
Async module | |||
------------ | |||
|
|||
.. automodule:: deezer.async | |||
.. automodule:: deezer.asyncclient |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Thanks for the PR, please don't bother with the typot comments, apologies for them, forgot to uninstall it. |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 3 3
Lines 201 201
Branches 22 22
=======================================
Hits 189 189
Misses 11 11
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for that. Looks like I commented a bit too late from the issue, but I'd prefer another name, either asynchronous
or async_client
. asyncclient
looks odd.
Also, feel free to add yourself to the list of Authors.
Thanks again!
Signed-off-by: Matheus Horstmann <[email protected]>
I add my name in the contributors, and also sorted alphabetically |
Signed-off-by: Matheus Horstmann <[email protected]>
Merged 🎉 |
…async to asynclient
Signed-off-by: Matheus Horstmann [email protected]