Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name files names and docs from async #28

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Change name files names and docs from async #28

merged 3 commits into from
Oct 1, 2018

Conversation

horstmannmat
Copy link
Contributor

@horstmannmat horstmannmat commented Oct 1, 2018

…async to asynclient

Signed-off-by: Matheus Horstmann [email protected]

  • Include tests for bug fix and new functionality
  • Updated documentation for new feature
  • The pull request should work for Python 2.7, 3.4, 3.5, 3.6 and for PyPy.
  • Added an entry at the top of History.rst, under the unreleased section

Copy link

@typot typot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review from typot

@@ -3,6 +3,6 @@ API Reference

.. toctree::

async
asyncclient

This comment was marked as outdated.

@@ -1,5 +1,5 @@
Async module
------------

.. automodule:: deezer.async
.. automodule:: deezer.asyncclient

This comment was marked as outdated.

@@ -1,5 +1,5 @@
Async module
------------

.. automodule:: deezer.async
.. automodule:: deezer.asyncclient

This comment was marked as outdated.

@browniebroke
Copy link
Owner

Thanks for the PR, please don't bother with the typot comments, apologies for them, forgot to uninstall it.

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files           3        3           
  Lines         201      201           
  Branches       22       22           
=======================================
  Hits          189      189           
  Misses         11       11           
  Partials        1        1
Impacted Files Coverage Δ
deezer/asynchronous.py 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3da4ed...6499da9. Read the comment docs.

@browniebroke browniebroke changed the title browniebroke/deezer-python#26: Change name files names and docs from … Change name files names and docs from async Oct 1, 2018
Copy link
Owner

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for that. Looks like I commented a bit too late from the issue, but I'd prefer another name, either asynchronous or async_client. asyncclient looks odd.

Also, feel free to add yourself to the list of Authors.

Thanks again!

@horstmannmat
Copy link
Contributor Author

I add my name in the contributors, and also sorted alphabetically

@browniebroke browniebroke merged commit 575718c into browniebroke:master Oct 1, 2018
@browniebroke
Copy link
Owner

Merged 🎉

@horstmannmat horstmannmat deleted the remove_async branch October 1, 2018 16:54
@browniebroke browniebroke added the breaking Breaking change. label Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants