Fix ComboSession implementation

The ComboSession example code is broken: since Cache::gc() returns void, parent::gc() is never called and garbage collection is never executed.
cakephp · Feb 4, 2025 · 1e4e5d6 · 1e4e5d6
1 parent 8485dee
commit 1e4e5d6
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/en/development/sessions.rst b/en/development/sessions.rst
@@ -280,7 +280,8 @@ something like::
         // Removes expired sessions.
         public function gc($expires = null)
         {
-            return Cache::gc($this->cacheKey) && parent::gc($expires);
+            Cache::gc($this->cacheKey);
+            return parent::gc($expires);
         }
     }
 

diff --git a/fr/development/sessions.rst b/fr/development/sessions.rst
@@ -300,7 +300,8 @@ devrait ressembler à::
         // Retire des sessions expirées.
         public function gc($expires = null)
         {
-            return Cache::gc($this->cacheKey) && parent::gc($expires);
+            Cache::gc($this->cacheKey);
+            return parent::gc($expires);
         }
     }
 

diff --git a/ja/development/sessions.rst b/ja/development/sessions.rst
@@ -270,7 +270,8 @@ IO をもたらします。
         // 有効期限切れセッションの削除
         public function gc($expires = null)
         {
-            return Cache::gc($this->cacheKey) && parent::gc($expires);
+            Cache::gc($this->cacheKey);
+            return parent::gc($expires);
         }
     }
 

diff --git a/pt/development/sessions.rst b/pt/development/sessions.rst
@@ -271,7 +271,8 @@ A classe deve se parecer com::
         // Remove sessões expiradas.
         public function gc($expires = null)
         {
-            return Cache::gc($this->cacheKey) && parent::gc($expires);
+            Cache::gc($this->cacheKey);
+            return parent::gc($expires);
         }
     }
 

diff --git a/ru/development/sessions.rst b/ru/development/sessions.rst
@@ -283,7 +283,8 @@ CakePHP предоставляет возможность настраивать
         // Удаление истёкших сессий.
         public function gc($expires = null)
         {
-            return Cache::gc($this->cacheKey) && parent::gc($expires);
+            Cache::gc($this->cacheKey);
+            return parent::gc($expires);
         }
     }