Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Typescript synthetic default imports #153

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Support Typescript synthetic default imports #153

merged 2 commits into from
Aug 12, 2019

Conversation

hugueschabot
Copy link
Contributor

Fixes #152

@goto-bus-stop goto-bus-stop self-requested a review August 12, 2019 08:49
goto-bus-stop
goto-bus-stop approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this looks good. we also have a babel plugin, but i assume most people configure typescript to output ES modules if they are going to run it through babel afterwards, so we probably don't need to support this variant there.

@goto-bus-stop goto-bus-stop merged commit 1637534 into choojs:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browserify transform does not work for code transpiled from Typescript
2 participants
@hugueschabot @goto-bus-stop