Add .match(router) method that returns a route without invoking a callback #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbachmann
force-pushed
the
add-match-method-of-wayfarer
branch
from
686a8d0 to
60fcd66
Compare
|
This looks good once |
marcbachmann
force-pushed
the
add-match-method-of-wayfarer
branch
from
60fcd66 to
d253163
Compare
|
@yoshuawuyts I updated the wayfarer dependency. So this would be ready to merge. edit: here's the pr for the api change: #13. It also includes this commit at the moment. So you can decide whether you want to merge this one first, do a minor bump or directly merge the other one with the major bump. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a first part of #8 without introducing any big changes. We'll first need to release choojs/wayfarer#64 to get that working with the published module.