-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(unenv-preset): sync directory structure with unenv #7915
base: main
Are you sure you want to change the base?
Conversation
|
packages/unenv-preset/package.json
Outdated
"unbuild": "^3.2.0", | ||
"undici": "catalog:default", | ||
"unenv": "file:/Users/vberchet/code/work/unenv", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really not sure about effect of this on resolution but it won't be same as normal installations in node_modules
.
We should adopt it with next rc (or nightly if you have it still working here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that was just pushing the changes that I have for (p)review.
This PR is in draft mode, I should have been more clear in the description.
@vicb Can you rebase? |
I will, probably tomorrow. For now this is only a preview syncing with the next version of unenv edit Jan 28: rebased and tested locally using |
631bbf7
to
ce8b989
Compare
Drop timers + rebased |
unenv: | ||
specifier: 2.0.0-rc.1 | ||
version: 2.0.0-rc.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's happening here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm link
to test the dev version as the new structure has not been released to npm.
Will need to be updated after the release and then remove draft from the PR
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-wrangler-7915 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7915/npm-package-wrangler-7915 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-wrangler-7915 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-workers-bindings-extension-7915 -O ./cloudflare-workers-bindings-extension.0.0.0-vf735271e1.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf735271e1.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-create-cloudflare-7915 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-kv-asset-handler-7915 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-miniflare-7915 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-pages-shared-7915 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-unenv-preset-7915 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-vite-plugin-7915 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-vitest-pool-workers-7915 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-workers-editor-shared-7915 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-workers-shared-7915 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13301360645/npm-package-cloudflare-workflows-shared-7915 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@petebacondarwin I have started to sync with unenv - there are still a few changes to sync. I also have 2 PRs on unenv that are pendings. This PR also needs to be tested with a version of wrangler actually using the preset - currently I hope to be done with that later today so that we can release |
778b8e4
to
fe14753
Compare
@petebacondarwin we need to fix The PR should be ready by tomorrow but feel free to take a look before. Thanks! |
Fixes a TS error with `import type { Preset } from "unenv";`
Sync the directory structure with unjs/unenv#392
edit Jan 28:
This PR is expected to fail until
[email protected]
is released (or whatever rc changes the unenv file structure, see unjs/unenv#392)It can be test locally in the unenv-preset folder via:
/cc @pi0 @petebacondarwin
Todo:
file:...
) when it is released