CNAB Security 1.0 GA #376
Merged
CNAB Security 1.0 GA #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radu M <[email protected]>
radu-matei
requested review from
technosophos,
jeremyrickard,
silvin-lubecki,
carolynvs and
jlegrone
technosophos
approved these changes
Jun 25, 2020
chris-crone
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
LGTM
Thanks @trishankatdatadog and @radu-matei for all the great work on this!
|
fantastic work, actually. amazing, tremendous labors all. On to the example and blog for it!!!! |
jlegrone
approved these changes
Jun 26, 2020
silvin-lubecki
approved these changes
Jun 30, 2020
|
So say we all 💯 |
|
Can someone put this on a branch that @chris-crone and I can vote on and tag? I think @vdice is the resident expert on this process. |
|
@technosophos the cnab-security-1.0.0-ga branch has now been created. It sounds like we'll wait on creation of the tag until the vote has been held. |
|
Chris and I both voted on this issue, but met today and re-confirmed that we believe the proposal is ready for release. Therefore, this proposal has been ratified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit marks the Working Group Acceptance (GA) of the CNAB Security 1.0 specification.
According to the OWNERS file, the following people must vote:
@radu-matei
@technosophos
@jeremyrickard
@silvin-lubecki
@jlegrone
@carolynvs
cc @chris-crone, @trishankatdatadog, @squillace