Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-774 remove .idea folder #76

Merged
merged 1 commit into from
Jul 21, 2015
Merged

CP-774 remove .idea folder #76

merged 1 commit into from
Jul 21, 2015

Conversation

maxwellpeterson-wf
Copy link
Contributor

Issue

Fixes #71. This will prevent the .idea directory from showing up in the npm artifact.

Changes

Source:

  • None.

Tests:

  • None.

Areas of Regression

  • None.

Testing

  • CI passes

@trentgrover-wf
@evanweible-wf
@dustinlessard-wf
FYI @jayudey-wf

@trentgrover-wf
Copy link
Collaborator

+1

@evanweible-wf
Copy link
Contributor

Additionally, everyone should make sure that .idea is in your global gitignore. Ideally, each individual project shouldn't have to add things like this to the .gitignore.

@evanweible-wf
Copy link
Contributor

+1

@maxwellpeterson-wf
Copy link
Contributor Author

@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title remove .idea folder CP-774 remove .idea folder Jul 21, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Jul 21, 2015
@jayudey-wf jayudey-wf merged commit 25fa286 into master Jul 21, 2015
@teresarevious-wf
Copy link
Contributor

@Rosie run_merge_script

@faridji
Copy link

faridji commented Aug 21, 2016

I can't be able to remove .idea files. How to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants