run.bats: check that we can run with symlinks in the bundle path

Make sure that we don't trigger error messages in runc when $TMPDIR, which affects os.TempDir(), is itself a symbolic link. Signed-off-by: Nalin Dahyabhai <[email protected]>
containers · Jun 1, 2018 · 2500139 · 2500139
1 parent 01a443f
commit 2500139
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/run.go b/run.go
@@ -705,7 +705,7 @@ func setupNamespaces(g *generate.Generator, namespaceOptions NamespaceOptions, i
 // Run runs the specified command in the container's root filesystem.
 func (b *Builder) Run(command []string, options RunOptions) error {
 	var user specs.User
-	p, err := ioutil.TempDir(os.TempDir(), Package)
+	p, err := ioutil.TempDir("", Package)
 	if err != nil {
 		return err
 	}

diff --git a/tests/run.bats b/tests/run.bats
@@ -335,3 +335,17 @@ load helpers
 	echo "$output"
 	[ "$status" -ne 0 ]
 }
+
+@test "run symlinks" {
+	if ! which runc ; then
+		skip
+	fi
+	runc --version
+	cid=$(buildah from --pull --signature-policy ${TESTSDIR}/policy.json alpine)
+	mkdir -p ${TESTDIR}/tmp
+	ln -s tmp ${TESTDIR}/tmp2
+	export TMPDIR=${TESTDIR}/tmp2
+	run buildah --debug=false run $cid id
+	echo "$output"
+	[ "$status" -eq 0 ]
+}