Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute path for bundlePath #745

Closed
wants to merge 1 commit into from
Closed

Conversation

baude
Copy link
Member

@baude baude commented Jun 1, 2018

When running buildah code on Atomic Hosts, we need to make sure
the absolute path for the bundlePath is used or operations
will fail.

Signed-off-by: baude [email protected]

When running buildah code on Atomic Hosts, we need to make sure
the absolute path for the bundlePath is used or operations
will fail.

Signed-off-by: baude <[email protected]>
@mheon
Copy link
Member

mheon commented Jun 1, 2018

Solves a persistent issue with Podman's CI we've been encountering. LGTM

@nalind
Copy link
Member

nalind commented Jun 1, 2018

LGTM

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming happy test. Going to give it a quick spin on a vm or two too.

@baude
Copy link
Member Author

baude commented Jun 1, 2018

I tested this on a F27AH

@nalind
Copy link
Member

nalind commented Jun 1, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit ecb2f8d has been approved by nalind

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit ecb2f8d with merge 01a443f...

@TomSweeneyRedHat
Copy link
Member

Passes the baseline tests on F28

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: nalind
Pushing 01a443f to master...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants