Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix R2025a Contributors List #6777

Open
wants to merge 2 commits into
base: released
Choose a base branch
from
Open

Fix R2025a Contributors List #6777

wants to merge 2 commits into from
+1 −2

Conversation

CoolSpy3
Copy link
Contributor

Description
In the same spirit as #6772. It looks like the contributors list in the R2025a release post is just the same one from the R2023b post. This PR rewrites the list based on contributions from R2023b..R2025a.

@CoolSpy3 CoolSpy3 requested a review from a team as a code owner February 16, 2025 07:54
@CoolSpy3 CoolSpy3 force-pushed the fix-R2025a-contributors branch from 18f5b02 to b39421a Compare February 16, 2025 07:55
lukicdarkoo
lukicdarkoo reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoolSpy3 Thank you for this, but there should be 22 contributors according to this list:
https://github.com/cyberbotics/webots/graphs/contributors?from=6%2F28%2F2023&to=2%2F23%2F2025
I see 31 in your list. How did you generate the list?

@CoolSpy3
Copy link
Contributor Author

I generated my list with git log --pretty="%an %ae%n%cn %ce" f3dc0950e2a747be9afe73941b6f5bd2a4dbe0ba..c6793d8f7230a311c4bc2a3101d9f1a8bc0aa01b | sort -u (Where f3dc095 and c6793d8 are the commit hashes for R2023b and R2025a respectively.) [1]

Diffing the two, I find that the following are included by this and not in GitHub's listing (Although I have no idea why).
Abdulrasheed1729 - Contributed in #6693
BenjaminDeleze - Contributed in #6401
Etaash-mathamsetty - Contributed in #6458
FrogGuaGuaGua - Contributed in #6523
matl-hsk - Contributed in #6390
amoor22 - Contributed in #6489
valeriyvan - Contributed in #6275
AntaresMKII - Contributed in #6568
yousefbilal - Contributed in #6491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukicdarkoo lukicdarkoo lukicdarkoo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CoolSpy3 @lukicdarkoo