You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See comments in #1065 for background. Load up data/warmech.bmp using notcurses-view -s none -b quadblitter. This is most easily seen in the 7th row in the right orange section. There are clearly cells which are all orange (there are only four colors in this bitmap, so it's not a slight RGB difference or anything). Yet the corresponding emitted EGC is an ▀, suggesting we're writing a U+2580 UPPER HALF BLOCK followed by equivalent upper and lower colors. This is unexpected. The most efficient encoding would be a U+0020 SPACE with the proper background color (the latter only if necessary).
▐▐▀▚▀▜▙▚▌▟▚▀▀▜▙▀▙▙▀▌
the halfblock blitter emits
▀ ▀▀ ▀▀▀▀▀▀ ▀ ▀ ▀▀▀▀
with efficient spaces where expected.
Note that the resulting render is still correct; it is merely inefficient (and possibly interacts poorly when under other planes; see #1065).
The text was updated successfully, but these errors were encountered:
OK, yes, this is pretty clear when you take a look at quadrant_solver() and quadrant_drivers -- no space is going to be emitted from them. A fully transparent cell ought, however, result in a NUL emission (transparency). hrmm.
See comments in #1065 for background. Load up
data/warmech.bmp
usingnotcurses-view -s none -b quadblitter
. This is most easily seen in the 7th row in the right orange section. There are clearly cells which are all orange (there are only four colors in this bitmap, so it's not a slight RGB difference or anything). Yet the corresponding emitted EGC is an▀
, suggesting we're writing aU+2580 UPPER HALF BLOCK
followed by equivalent upper and lower colors. This is unexpected. The most efficient encoding would be aU+0020 SPACE
with the proper background color (the latter only if necessary).▐▐▀▚▀▜▙▚▌▟▚▀▀▜▙▀▙▙▀▌
the halfblock blitter emits
▀ ▀▀ ▀▀▀▀▀▀ ▀ ▀ ▀▀▀▀
with efficient spaces where expected.
Note that the resulting render is still correct; it is merely inefficient (and possibly interacts poorly when under other planes; see #1065).
The text was updated successfully, but these errors were encountered: