Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alignment in ncdirect_visual_render() #1195

Closed
dankamongmen opened this issue Dec 9, 2020 · 2 comments
Closed

Support alignment in ncdirect_visual_render() #1195

dankamongmen opened this issue Dec 9, 2020 · 2 comments
Assignees
@dankamongmen
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
2.2.0

Comments

@dankamongmen
Copy link
Owner

dankamongmen commented Dec 9, 2020 •
edited
Loading

@kusky3 suggested in #1194 that we support ncls displaying along the left side of the terminal. This is trivial if we amend ncdirect_render_visual() to have that capability. Seems like a reasonable thing to do. Base this off ncalign_e so we also have centering.

Currently, we only support right-justification.
@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 9, 2020
@dankamongmen dankamongmen self-assigned this Dec 9, 2020
@dankamongmen dankamongmen added this to the 2.2.0 milestone Dec 9, 2020
@dankamongmen dankamongmen mentioned this issue Dec 9, 2020
Closed
@dankamongmen
Copy link
Owner Author

ncdirect_render_image() already supports an ncalign_e variable, hah! so it's just a matter of exposing this to the user in ncls.

dankamongmen added a commit that referenced this issue Dec 14, 2020
@dankamongmen
ncls: add --align argument #1195
6b859b6
@dankamongmen
Copy link
Owner Author

It appears to work perfectly. I've added -a/--align, accepting one of left, right, or center. They work as you would expect. I've updated the man page and the usage output. This will be present in 2.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@dankamongmen