-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the holopin.yml to use the sdk badge by default #1038
Conversation
Signed-off-by: Eudris Cabrera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
============================================
+ Coverage 76.91% 77.61% +0.70%
+ Complexity 1592 1571 -21
============================================
Files 145 144 -1
Lines 4843 4767 -76
Branches 562 554 -8
============================================
- Hits 3725 3700 -25
+ Misses 821 781 -40
+ Partials 297 286 -11 ☔ View full report in Codecov by Sentry. |
@mukundansundar any idea why some builds failed? In case the errors are transient, could you re-run them? |
Signed-off-by: Eudris Cabrera <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: SanchAnt <[email protected]>
@holopin-bot @ecabrerar Enjoy the Dapr SDK badge! |
Congratulations @ecabrerar, you just earned a badge! Here it is: https://holopin.io/claim/clxj4x0fw20950cjjc9pi03bg This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
updating the holopin.yml to use the sdk badge by default
Issue reference
#1032
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: