Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the holopin.yml to use the sdk badge by default #1038

Merged
merged 2 commits into from
May 9, 2024

Conversation

ecabrerar
Copy link
Contributor

Description

updating the holopin.yml to use the sdk badge by default

Issue reference

#1032

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@ecabrerar ecabrerar requested review from a team as code owners April 24, 2024 04:50
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukundansundar mukundansundar added this to the v1.12 milestone Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (d759c53) to head (5f9adf3).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1038      +/-   ##
============================================
+ Coverage     76.91%   77.61%   +0.70%     
+ Complexity     1592     1571      -21     
============================================
  Files           145      144       -1     
  Lines          4843     4767      -76     
  Branches        562      554       -8     
============================================
- Hits           3725     3700      -25     
+ Misses          821      781      -40     
+ Partials        297      286      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcduiker
Copy link
Contributor

@mukundansundar any idea why some builds failed? In case the errors are transient, could you re-run them?

@artursouza artursouza merged commit a074310 into dapr:master May 9, 2024
9 of 12 checks passed
antoniomaria pushed a commit to antoniomaria/java-sdk that referenced this pull request May 23, 2024
Signed-off-by: Eudris Cabrera <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: SanchAnt <[email protected]>
@marcduiker
Copy link
Contributor

@holopin-bot @ecabrerar Enjoy the Dapr SDK badge!

Copy link

holopin-bot bot commented Jun 17, 2024

Congratulations @ecabrerar, you just earned a badge! Here it is: https://holopin.io/claim/clxj4x0fw20950cjjc9pi03bg

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants