Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17863: Adds validation to ext field in phone paragraph. #20651

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Feb 21, 2025

Description

Adds numeric validator and applies it to the extension field of the phone paragraph.

Relates to #17863

Testing done

Manual
Cypress
Unit

Screenshots

Screenshot 2025-02-19 at 12 22 03 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

Blocked by #20611

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2025 18:30 Destroyed
Copy link

Checking composer.lock changes...

});
},
};
})(jQuery, Drupal, once);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-undef> reported by reviewdog 🐶
'once' is not defined.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2025 18:46 Destroyed
Copy link

Checking composer.lock changes...

Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@github-actions github-actions bot added DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc) labels Feb 21, 2025
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2025 19:31 Destroyed
Copy link

Checking composer.lock changes...

…' of github.com:department-of-veterans-affairs/va.gov-cms into VACMS-17863-add-validation-ext-field-in-phone-paragraph
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2025 20:40 Destroyed
Copy link

Checking composer.lock changes...

foreach ($items as $delta => $item) {
if (!preg_match("/^\d+$/", $item->value)) {
$this->getContext()
->buildViolation($constraint->notANumber, [])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PHPStan] reported by reviewdog 🐶
Access to an undefined property Symfony\Component\Validator\Constraint::$notANumber.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2025 21:05 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 22, 2025 08:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 23, 2025 08:49 Destroyed
@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-voluptates

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants