-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-17863: Adds validation to ext field in phone paragraph. #20651
base: main
Are you sure you want to change the base?
VACMS-17863: Adds validation to ext field in phone paragraph. #20651
Conversation
…ation-ext-field-in-phone-paragraph
Checking composer.lock changes... |
}); | ||
}, | ||
}; | ||
})(jQuery, Drupal, once); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking composer.lock changes... |
GitHub Workflows (.github/workflows/*.yml)Have you...
|
Checking composer.lock changes... |
…' of github.com:department-of-veterans-affairs/va.gov-cms into VACMS-17863-add-validation-ext-field-in-phone-paragraph
Checking composer.lock changes... |
foreach ($items as $delta => $item) { | ||
if (!preg_match("/^\d+$/", $item->value)) { | ||
$this->getContext() | ||
->buildViolation($constraint->notANumber, []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PHPStan] reported by reviewdog 🐶
Access to an undefined property Symfony\Component\Validator\Constraint::$notANumber.
Checking composer.lock changes... |
Cypress Accessibility Violations
|
Description
Adds numeric validator and applies it to the extension field of the phone paragraph.
Relates to #17863
Testing done
Manual
Cypress
Unit
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As user uid with user_role
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
Blocked by #20611
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review