Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When changing active files quickly, opening startup file may fail #18

Closed
kzu opened this issue Feb 12, 2021 · 0 comments · Fixed by #20
Closed

When changing active files quickly, opening startup file may fail #18

kzu opened this issue Feb 12, 2021 · 0 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@kzu
Copy link
Member

kzu commented Feb 12, 2021

This manifests in a "program is busy" indicator and a Debug.Fail (in debug builds), when we invoke File.OpenFile via the DTE.

Add some resiliency there, with some timeout and retries so that we can give VS time to respond to user actions before we run our command.
@kzu kzu added the bug Something isn't working label Feb 12, 2021
kzu added a commit that referenced this issue Feb 12, 2021
@kzu
Improve resiliency when invoking DTE
712a1d8 
Various minor improvements including:

* Not starting the active document monitoring until initial build completes
* Retrying opening of the startup file if ExecuteCommand fails (IDE might be busy doing something else on the UI thread)
* Not trying to open startup file if we can't determine which one
* Some troubleshooting aids by capturing thrown exceptions for Debug.Fail diagnostics

Fixes #18
@kzu kzu mentioned this issue Feb 12, 2021
Merged
kzu added a commit that referenced this issue Feb 12, 2021
@kzu
Improve resiliency when invoking DTE
9aca5ed 
Various minor improvements including:

* Not starting the active document monitoring until initial build completes
* Retrying opening of the startup file if ExecuteCommand fails (IDE might be busy doing something else on the UI thread)
* Not trying to open startup file if we can't determine which one
* Some troubleshooting aids by capturing thrown exceptions for Debug.Fail diagnostics

Fixes #18
@kzu kzu closed this as completed in #20 Feb 12, 2021
kzu added a commit that referenced this issue Feb 12, 2021
@kzu
Improve resiliency when invoking DTE
00c37d3 
Various minor improvements including:

* Not starting the active document monitoring until initial build completes
* Retrying opening of the startup file if ExecuteCommand fails (IDE might be busy doing something else on the UI thread)
* Not trying to open startup file if we can't determine which one
* Some troubleshooting aids by capturing thrown exceptions for Debug.Fail diagnostics

Fixes #18
@devlooped devlooped locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve resiliency when invoking DTE devlooped/SmallSharp
1 participant
@kzu