feat: added validation for create app workflow API #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
approved these changes
Aug 30, 2023
iamayushm
previously approved these changes
Aug 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
iamayushm
approved these changes
Sep 4, 2023
Shivam-nagar23
pushed a commit
that referenced
this pull request
Sep 12, 2023
* feat: added validation for create app workflow * fixed: CiPipelineDetails validation * fixed: virtual env validation * fixed: validation struct * fixed: validation struct * fixed: validation struct * chore: renamed a function * fixed: updated validation * updated: validation for linked CI
vikramdevtron
added a commit
that referenced
this pull request
Sep 13, 2023
* rbac-modification * rbac modification changes * handling conditiin of empty envs * refactoring and rbac in description * refactoring * rbac chaneg for node detail and node list * Refactoring into rbacClusterService * review change * added new api for api resources gvk list * fix makefile for shallow clone release * added: migration script (#3870) * feat: added validation for create app workflow API (#3842) * feat: added validation for create app workflow * fixed: CiPipelineDetails validation * fixed: virtual env validation * fixed: validation struct * fixed: validation struct * fixed: validation struct * chore: renamed a function * fixed: updated validation * updated: validation for linked CI * feat: deployment history release not found err handling (#3811) * query optimised (#3877) * fixed: deployment history user details (#3873) * chore: adjust duplicate action threshold (#3879) --------- Co-authored-by: Vikram Singh <[email protected]> Co-authored-by: Asutosh Das <[email protected]> Co-authored-by: Gireesh Naidu <[email protected]> Co-authored-by: Prakarsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API for creating Devtron App Workflow : /orchestrator/core/v1beta1/application/workflow, will create invalid CI Material incase of linked CI if the payload contains invalid GitMaterialId. As it creates the workflow successfully with corrupted data, we will not be able to update branch name in linked CI pipeline. This PR adds validation to the createAppWorkflow API
Fixes #3827
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?