Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GitOps async install for devtron applications #5169

Merged
merged 95 commits into from
Jun 19, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented May 26, 2024

Description

Currently in Devtron Apps with GitOps installation, we are performing the Install/Upgrade in synchronous mode. With this flow, in some cases the API context expires as the Install/ Upgrade may take too long. Also Auto Deployments can block the CI Success event delivery.

The common case for this behaviour is if the git commit took an unreasonable time than expected.

This PR provides the feature to perform GitOps install/ Upgrade for devtron Apps in asynchronous mode.

Fixes #5323

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented May 26, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret b210fbe charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret b210fbe charts/devtron/values.yaml View secret
10190660 Triggered Generic Password cb9f65b tests/integrationTesting/devtron-secret.yaml View secret
2763127 Triggered Generic High Entropy Secret 0947c75 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 0947c75 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Ash-exp Ash-exp self-assigned this May 26, 2024
@Ash-exp Ash-exp requested a review from ashokdevtron as a code owner June 10, 2024 14:24
@Ash-exp Ash-exp requested a review from pawan-mehta-dt as a code owner June 11, 2024 09:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Ash-exp Ash-exp merged commit 63b46fd into main Jun 19, 2024
7 of 8 checks passed
@Ash-exp Ash-exp deleted the feat-devtron-gitops-async branch June 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Devtron App GitOps Install In Async Mode
3 participants