-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GitOps async install for devtron applications #5169
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10220829 | Triggered | Generic High Entropy Secret | b210fbe | charts/devtron/devtron-bom.yaml | View secret |
10220829 | Triggered | Generic High Entropy Secret | b210fbe | charts/devtron/values.yaml | View secret |
10190660 | Triggered | Generic Password | cb9f65b | tests/integrationTesting/devtron-secret.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | 0947c75 | scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | 0947c75 | scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Description
Currently in Devtron Apps with GitOps installation, we are performing the Install/Upgrade in synchronous mode. With this flow, in some cases the API context expires as the Install/ Upgrade may take too long. Also Auto Deployments can block the CI Success event delivery.
The common case for this behaviour is if the git commit took an unreasonable time than expected.
This PR provides the feature to perform GitOps install/ Upgrade for devtron Apps in asynchronous mode.
Fixes #5323
Checklist:
Does this PR introduce a user-facing change?