Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nats consumer deleted on shutdown #5377

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jun 27, 2024

Description

Update on common-lib: Currently we create Ephemeral consumers by NATS Subscribe method. but with the introduction of NATS graceful shutdown using Drain() function. the NATS client deletes durable consumers that it created during QueueSubscribe(). Need to properly handle this condition first until then reverting the graceful shutdown implementation.

Fixes #5323

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Ash-exp Ash-exp added the enhancement New feature or request label Jun 27, 2024
@Ash-exp Ash-exp self-assigned this Jun 27, 2024
Copy link

@Ash-exp Ash-exp merged commit 00cc245 into main Jun 27, 2024
7 checks passed
@Ash-exp Ash-exp deleted the fix-nats-consumer-delete branch June 27, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Devtron App GitOps Install In Async Mode
2 participants