Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override clusterRbac with direct allow behaviour for super admin #5449

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: override clusterRbac with direct allow behaviour for super admin #5449

merged 1 commit into from
Jul 5, 2024

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Jul 5, 2024 •
edited
Loading

Description

Fixes #5417

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gireesh-naidu gireesh-naidu merged commit b425271 into main Jul 5, 2024
7 of 8 checks passed
@gireesh-naidu gireesh-naidu deleted the resource-list-v2-panic branch July 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Explicit RBAC checks not required for Super-admins
2 participants
@gireesh-naidu @kripanshdevtron