Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm rollback in case of no gitops #6005

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Conversation

RajeevRanjan27
Copy link
Contributor

Description

Fixes https://github.com/devtron-labs/devops-sprint/issues/1011

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Oct 22, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
141558 Triggered Generic High Entropy Secret 7147954 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 7147954 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 7147954 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml View secret
9257608 Triggered Base64 AWS keys 7147954 scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 7147954 scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Ash-exp
Ash-exp previously approved these changes Oct 23, 2024
iamayushm
iamayushm previously approved these changes Oct 28, 2024
Copy link
Contributor

@iamayushm iamayushm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check rollback for apps installed in EA mode, that should we also modify this check "util2.IsHelmApp(installedApp.AppOfferingMode)" in GetDeploymentHistory function to installedAppId>0 . did we checked this case in QA?

@RajeevRanjan27
Copy link
Contributor Author

please check rollback for apps installed in EA mode, that should we also modify this check "util2.IsHelmApp(installedApp.AppOfferingMode)" in GetDeploymentHistory function to installedAppId>0 . did we checked this case in QA?

for ea mode rollback we have handled the case inside the GetDeploymentHistory function with installedAppId>0

Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@RajeevRanjan27 RajeevRanjan27 merged commit c684954 into develop Nov 4, 2024
3 of 4 checks passed
@RajeevRanjan27 RajeevRanjan27 deleted the fix-helm-rollback branch November 4, 2024 12:41
vikramdevtron added a commit that referenced this pull request Nov 4, 2024
misc: helm rollback in case of no gitops (#6005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants