-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: helm rollback in case of no gitops #6005
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
141558 | Triggered | Generic High Entropy Secret | 7147954 | scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/env-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | 7147954 | scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/secrets-test-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | 7147954 | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/env-values.yaml | View secret |
9257608 | Triggered | Base64 AWS keys | 7147954 | scripts/devtron-reference-helm-charts/deployment-chart_4-20-0/test-values.json | View secret |
2763127 | Triggered | Generic High Entropy Secret | 7147954 | scripts/devtron-reference-helm-charts/reference-chart_4-19-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
pkg/appStore/installedApp/service/EAMode/InstalledAppDBService.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check rollback for apps installed in EA mode, that should we also modify this check "util2.IsHelmApp(installedApp.AppOfferingMode)" in GetDeploymentHistory function to installedAppId>0 . did we checked this case in QA?
|
|
misc: helm rollback in case of no gitops (#6005)
Description
Fixes https://github.com/devtron-labs/devops-sprint/issues/1011
Checklist:
Does this PR introduce a user-facing change?