fix: fix for showing inaccurate data in template/list api while fetching previous deployments list in template/list api, output shown was cartesian product of deployment_template_history and wfr #6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d another and sql clause to filter pipeline on
prakash100198
requested review from
vikramdevtron,
nishant-d and
prakarsh-dt
as code owners
prakash100198
changed the title
prakash100198
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
vikramdevtron
approved these changes
Oct 27, 2024
vikramdevtron
previously approved these changes
Oct 27, 2024
|
vikramdevtron
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the case when we show inaccurate data in template/list api while fetching previous deployments list in template/list api, output shown was cartesian product of deployment_template_history.deployed_on and wfr.started_on, because in case of SDH we store same deployed_on in wfr table for all the pipeline.
Fixes #6035
Checklist:
Does this PR introduce a user-facing change?