-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Argocd repository secret creation service refactoring #6229
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14998970 | Triggered | Generic Password | d0755c6 | pkg/argoRepositoryCreds/repositoryCredsManager.go | View secret |
463396 | Triggered | Generic Password | d0755c6 | pkg/chartRepo/ChartRepositoryService.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
The migration files have successfully passed the criteria!! |
1 similar comment
The migration files have successfully passed the criteria!! |
…secret-refactoring
The migration files have successfully passed the criteria!! |
…secret-refactoring
The migration files have successfully passed the criteria!! |
|
Description
For adding repository creds in argocd for helm apps we add repo in argocd-cm(deprecated) or create repository secret for same.In this PR, intent is to move all this code into a common place.
Checklist:
Does this PR introduce a user-facing change?