Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Argocd repository secret creation service refactoring #6229

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Dec 29, 2024

Description

For adding repository creds in argocd for helm apps we add repo in argocd-cm(deprecated) or create repository secret for same.In this PR, intent is to move all this code into a common place.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Dec 29, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14998970 Triggered Generic Password d0755c6 pkg/argoRepositoryCreds/repositoryCredsManager.go View secret
463396 Triggered Generic Password d0755c6 pkg/chartRepo/ChartRepositoryService.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

The migration files have successfully passed the criteria!!

1 similar comment
Copy link

The migration files have successfully passed the criteria!!

Copy link

github-actions bot commented Jan 1, 2025

The migration files have successfully passed the criteria!!

Copy link

github-actions bot commented Jan 2, 2025

The migration files have successfully passed the criteria!!

Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8 Security Hotspots
27.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@iamayushm iamayushm merged commit de8652b into develop Jan 2, 2025
5 of 6 checks passed
@iamayushm iamayushm deleted the argocd-repository-secret-refactoring branch January 2, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants