Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: casbin db creation call removed #6238

Merged
merged 2 commits into from
Dec 31, 2024
Merged

fix: casbin db creation call removed #6238

merged 2 commits into from
Dec 31, 2024

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Dec 30, 2024 •
edited
Loading

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1402

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kartik-579 kartik-579 changed the base branch from main to develop December 30, 2024 14:30
@github-actions GitHub Actions
Copy link

The migration files have successfully passed the criteria!!

@github-actions GitHub Actions
Copy link

The migration files have successfully passed the criteria!!

@kartik-579 kartik-579 merged commit df4beab into develop Dec 31, 2024
4 checks passed
@kartik-579 kartik-579 deleted the casbin-call-fix branch December 31, 2024 05:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartik-579 @vikramdevtron