Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspire solution templates should check for CLI host rather than VS host #3951

Closed
DamianEdwards opened this issue Apr 25, 2024 · 0 comments · Fixed by #3953
Closed

Aspire solution templates should check for CLI host rather than VS host #3951

DamianEdwards opened this issue Apr 25, 2024 · 0 comments · Fixed by #3953
Assignees
@DamianEdwards
Labels
area-templates

Comments

@DamianEdwards
Copy link
Member

The Aspire solution templates currently special case the VS host and don't generate a .sln file in that case. Instead they should special case the CLI host and only generate a .sln file in this case. This will make them aligned with the Blazor solution templates and work correctly in other non-CLI hosts like VS Code C# Dev Kit.
@DamianEdwards DamianEdwards added this to the GA milestone Apr 25, 2024
@DamianEdwards DamianEdwards self-assigned this Apr 25, 2024
DamianEdwards added a commit that referenced this issue Apr 25, 2024
@DamianEdwards
Update sln templates to special-case CLI instead of VS
168f6ed 
Fixes #3951
@DamianEdwards DamianEdwards mentioned this issue Apr 25, 2024
Merged
github-actions bot pushed a commit that referenced this issue Apr 25, 2024
@DamianEdwards
Update sln templates to special-case CLI instead of VS
c2c5de8 
Fixes #3951
DamianEdwards added a commit that referenced this issue Apr 25, 2024
@DamianEdwards
Update sln templates to special-case CLI instead of VS (#3953)
fe190c6 
* Update sln templates to special-case CLI instead of VS

Fixes #3951

* Fix primary outputs
danmoseley pushed a commit that referenced this issue Apr 25, 2024
@github-actions @DamianEdwards
[release/8.0] Update sln templates to special-case CLI instead of VS (#…
7ed4709 
…3954)

* Update sln templates to special-case CLI instead of VS

Fixes #3951

* Fix primary outputs

---------

Co-authored-by: Damian Edwards <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DamianEdwards DamianEdwards

Labels
area-templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update sln templates to special-case CLI instead of VS dotnet/aspire
1 participant
@DamianEdwards