#2367 dapr change the app port depending on the app protocol

[paule96]

if you dapr connected apps uses anything else then http they will currently not correctly connecting to the sidecare. (more details to that issue in #2367 )

To fix this now, a use can set the app protocol in the sidecare options and this will then take the correct endpoint information.

Open questions:

• Can someone test the playground project for dapr?
  • for me on Linux it seems to be broken in

Microsoft Reviewers: Open in CodeFlow

[paule96]

okay, I know now why the playground project is not working. There seems to be a bug unrelated to this PR that it is required to have dapr 1.13.0 as a reference for aspire >= preview 4.
The problem is there is only dapr 1.12.0 available on the feeds configured in the NuGet.config.

[paule96]

Okay after I integrated locally the nuget.org feed I was able to test my change. For me it looks like it is working.

[paule96]

@davidfowl and @karolz-ms,

because you both were involved in #3305 can I ask you to review this PR too?

[paule96]

@davidfowl please review again :) I changed the logic and also added tests

[davidfowl]

This looks great

[karolz-ms]

Looks great overall, thanks so much @paule96 for taking care of this. I have just one question regarding the use of targetPortExpression in the test

[davidfowl]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8654197627

[github-actions]

@davidfowl backporting to release/8.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: dapr change the app port depending on the app protocol
Applying: fix endpoint annotations for dapr.
error: sha1 information is lacking or useless (src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 fix endpoint annotations for dapr.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[github-actions]

@davidfowl an error occurred while backporting to release/8.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.