Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Allow cert warnings to bubble out. #3217

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 27, 2024

Backport of #3212 to release/8.0-preview5

/cc @davidfowl @mitchdenny

Customer Impact

If the ASP.NET Core developer certificate isn't trusted, currently no warnings show up anywhere on the console except for the browser. This change shows the normal warning in the output of the app host which has instructions on how to trust the https certificate.

Testing

Manual.

Risk

Very low.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 27, 2024
@davidfowl davidfowl enabled auto-merge (squash) March 27, 2024 14:56
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit d81dc61 into release/8.0-preview5 Mar 27, 2024
7 checks passed
@davidfowl davidfowl deleted the backport/pr-3212-to-release/8.0-preview5 branch March 27, 2024 18:10
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants