Updating to RC of OTel #3316
Closed
Updating to RC of OTel #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new UseOtlpExporter simplified hookup
sebastienros
reviewed
Apr 1, 2024
| @@ -12,8 +12,8 @@ | |||
|
|
|||
| <PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="!!REPLACE_WITH_EXTENSIONS_VERSION!!" /> | |||
| <PackageReference Include="Microsoft.Extensions.ServiceDiscovery" Version="!!REPLACE_WITH_LATEST_VERSION!!" /> | |||
| <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.7.0" /> | |||
| <PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.7.0" /> | |||
| <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.8.0-rc.1" /> | |||
There was a problem hiding this comment.
Can you confirm the bar to use non-stable packages is that they ship stable before we go GA?
There was a problem hiding this comment.
Yes, the goal is to get them to stable. This is to validate that all that we need is in there.
sebastienros
approved these changes
Apr 1, 2024
|
@samsp-msft what about these -- that's what I assumed we want to update https://github.com/dotnet/aspire/blob/main/Directory.Packages.props#L106-L112 |
|
Maybe let's also wait for 1.8.0 which should ship today (as Eric mentioned). |
eerhardt
reviewed
Apr 2, 2024
...re.ProjectTemplates/templates/aspire-empty/AspireApplication.1.ServiceDefaults/Extensions.cs
Show resolved
Hide resolved
added 2 commits
April 3, 2024 09:53
…sft/aspire into samsp/update_otel_1_8_rc
|
duplicate of #3351 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new UseOtlpExporter simplified hookup
Microsoft Reviewers: Open in CodeFlow