[release/8.0] Update table every second, reuse existing metric values if possible #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
the
Servicing-consider
adamint
requested review from
JamesNK and
kvenkatrajan
and removed request for
JamesNK
kvenkatrajan
approved these changes
Apr 17, 2024
|
How did we pick 1 second and how do we know that is meaningfully an improvement over 0.2 seconds? Is there a relevant accessibility standard? I would have expect it to be something much larger, or require a way to pause updates. |
danmoseley
added
Servicing-approved
RussKie
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3370 to release/8.0
/cc @adamint
Customer Impact
Tenet: accessibility - compliance. Keyboard users are unable to consistently focus the tabular view of a metric without focus being lost. This impedes their ability to navigate to all rows in the table and understand the metric data.
Testing
Manual testing by myself. Keyboard focus is no longer lost.
Risk
Low risk as there are no visual updates, only a key is added to associate an item with a date.
Regression?
No
Microsoft Reviewers: Open in CodeFlow