Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Aspire.Hosting.Garnet.Tests project #4871

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Extract Aspire.Hosting.Garnet.Tests project #4871

merged 9 commits into from
Jul 29, 2024

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Jul 12, 2024 •
edited
Loading

Contributes to #3185
Contributes to #4294

Microsoft Reviewers: Open in CodeFlow

@Alirexaa Alirexaa requested a review from mitchdenny as a code owner July 12, 2024 10:04
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 12, 2024
@Alirexaa
Copy link
Contributor Author

@eerhardt, we need to import microsoft/garnet:1.0 to netaspireci.azurecr.io.

@Alirexaa
Copy link
Contributor Author

This PR needs more work to do:
Garnet WithPersistence does not work according to #4870.
We need to fix that and then add a functional test for that.

@Alirexaa Alirexaa mentioned this pull request Jul 12, 2024
Closed
16 tasks
@build-analysis build-analysis bot mentioned this pull request Jul 12, 2024
Closed
@eerhardt eerhardt mentioned this pull request Jul 12, 2024
Closed
20 tasks
@eerhardt
Copy link
Member

@eerhardt, we need to import microsoft/garnet:1.0 to netaspireci.azurecr.io.

We reference microsoft/garnet from ghcr.io and not DockerHub. So we shouldn't need to use our docker hub mirror.

@eerhardt
Copy link
Member

Can we remove the reference from

aspire/tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj

Line 32 in f38b6cb

<ProjectReference Include="..\..\src\Aspire.Hosting.Garnet\Aspire.Hosting.Garnet.csproj" IsAspireProjectResource="false" />

@Alirexaa
Copy link
Contributor Author

Can i fix #4870 in this PR?
@eerhardt

@eerhardt
Copy link
Member

Can i fix #4870 in this PR? @eerhardt

I'd prefer if they were separate. One PR == one change. So make a PR that extracts the tests. And another PR that fixes the issue.

@Alirexaa
Copy link
Contributor Author

Can i fix #4870 in this PR? @eerhardt

I'd prefer if they were separate. One PR == one change. So make a PR that extracts the tests. And another PR that fixes the issue.

I will send another PR for that.

@Alirexaa
Copy link
Contributor Author

@eerhardt, please take a look, this should be enough at this moment.

@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jul 24, 2024
eerhardt
eerhardt reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Alirexaa.

Can you also add functional tests for WithDataVolume and WithDataBindMount?

@Alirexaa
Copy link
Contributor Author

Thanks for the contribution, @Alirexaa.

Can you also add functional tests for WithDataVolume and WithDataBindMount?

I will do, but those tests not pass until #5087

@eerhardt
Copy link
Member

I will do, but those tests not pass until #5087

oh right. I forgot about that. Sorry.

eerhardt
eerhardt approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@eerhardt eerhardt merged commit 7eefa05 into dotnet:main Jul 29, 2024
9 checks passed
@Alirexaa Alirexaa deleted the garnet-tests branch July 29, 2024 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@radical radical Awaiting requested review from radical radical is a code owner

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member testing ☑️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alirexaa @eerhardt @radical