-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle parsing wildcard urls in launch profiles #5588
Conversation
- As part of this change expose TargetHostAddress on EndpointAnnotation which describes the original address that was bound to in both the kestrel endpoint list and the launch profile's application urls. - Added a test Fixes #5587
cc @davidebbo |
What impact does this have around requests that are proxied via DCP? I would have thought that for this to be useful the proxy would need to pass through a host header? |
For proxied URLs, I think we could make this useful for DCP by setting the binding address (I think that is supported) to 0.0.0.0 if the input is *. I didn't want to tackle that in this PR though as there are potentially security implications. That said, the behavior now not be what is expected if the url is proxied. We'll end up with the app binding on all interfaces but the dcp proxy using that port and binding to localhost. It will work but may not have the desired effect. PS: This is what happens today with kestrel endpoints defined as *. We ignore this for DCP's binding and use localhost. |
- We still treat this allocated endpoint as being accessible via localhost only in the ux
OK I made a change to tell the dcp service about the address. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Fixes #5587
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow