-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update container lifetime API and add schema for lifecycleKey property #5630
Conversation
Now I think we should spend some time bikeshedding about that name of this enum. If it's this explicit (and long) then we might need a helper method. |
|
@mitchdenny @davidfowl @DamianEdwards do we want to go with the verbose |
I think I want to keep the name persistent and add a giant doc comment for what that means instead of encapsulating it in the name with a really long enum. |
I reverted the name and made a pass at a more comprehensive doc comment, but I feel like the description of the behavior could still use a bit more work. |
I'll merge this since we're happy with the API; any future improvements to the doc comment can be made in a follow up PR. |
Description
Renames the
WithContainerLifetime
experimental API toWithLifetime
, changes theContainerLifetimeType
enum toContainerLifetime
and renamesContainerLifetimeType.Persistent
toContainerLifetime.CreateIfNotExistsPersistOnExit
as a more explicit description of the lifetime behavior.Adds DCP schema for
lifecycleKey
which can be used to configure the lifetime of persistent containers (if not set, DCP will calculate a default lifecycle key value). If set, DCP will check existing persistent containers for to see if they have a matching lifecycle key. If not, the container will be destroyed and re-created based on the new AppHost config.Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow