Don't add nested code actions *and* their parent to the smart tag list. #6797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,6 +220,7 @@ private SuggestedActionSet InlineActions(SuggestedActionSet actionSet) | |||
| } | |||
|
|
|||
| newActions.AddRange(childActionSets[0].Actions); | |||
| continue; | |||
| } | |||
|
|
|||
| newActions.Add(action); | |||
There was a problem hiding this comment.
Why not remove the continue and wrap this line in an else { }? It (should) accomplish the same thing and it's easier to look at.
There was a problem hiding this comment.
Stylistically, i prefer the above. I literally cannot explain why as it's purely subjective.
If it's important to you, i can change though as i don't really care that much :)
|
|
|
👍 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Nov 16, 2015
Don't add nested code actions *and* their parent to the smart tag list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6753
Tagging @dotnet/roslyn-ide