Provide a faster implementation of Fuzzy Searching for 'Add Using'. #7390
Conversation
|
Tagging @dpoeschl |
| var currentNode = _builderNodes[currentNodeIndex]; | ||
|
|
||
| var editDistance = EditDistance.GetEditDistance(currentNode.LowerCaseCharacters, lowerCaseCharacters); | ||
| // This shoudl never happen. We dedupe all items before proceeding to the 'Add' step. |
CyrusNajmabadi
force-pushed
the
fuzzyMatchingIndex
branch
3 times, most recently
from
83757ce to
aad4ebd
Compare
| // of children along with each node. However, this would be very inefficient and would | ||
| // put an enormous amount of memory pressure on the system. | ||
| // | ||
| // Imperical data for a nice large assembly like mscorlib gives us the following |
There was a problem hiding this comment.
This is in Utilities, so you should probably add more context here, that you added all names in mscorlib and got this distribution.
CyrusNajmabadi
force-pushed
the
fuzzyMatchingIndex
branch
from
18056eb to
16aca85
Compare
|
Linux failure due to #7411. |
| switch (kind) | ||
| { | ||
| case SearchKind.Exact: | ||
| _predicate = s => StringComparer.Ordinal.Equals(name, s); |
There was a problem hiding this comment.
Can't. It captures the parameter to the outer method.
|
retest this please |
CyrusNajmabadi
force-pushed
the
fuzzyMatchingIndex
branch
from
a36050d to
8a88586
Compare
|
test vsi please |
CyrusNajmabadi
force-pushed
the
fuzzyMatchingIndex
branch
2 times, most recently
from
1ccf2b3 to
da98648
Compare
|
test vsi please |
1 similar comment
|
test vsi please |
| // y |∞ 8 * | ||
| // | ||
| // And then consider a point above that diagonal (indicated by x). In the example | ||
| // above, the edit distance to * from + will be (x+4). If, for example, threshold |
CyrusNajmabadi
force-pushed
the
fuzzyMatchingIndex
branch
from
47605ca to
eac1ed2
Compare
Provide a faster implementation of Fuzzy Searching for 'Add Using'.
|
@CyrusNajmabadi Does the BKTree creation only happen when you first ctrl+dot in a way that triggers add using? Or is it done earlier than that, on idle or something? I think we said the other day that it won't be done earlier due to some bug -- is something tracking that? |
|
The BKTrees will currently happen when asked for for ctrl-dot (or if we're trying to decide if we should show the lightbulb or not). There is nothing tracking any work to make the index construction happen any sooner than it already did before the addition of these trees. |
This change refactors things to move fuzzy searching to a BK-tree implementatoin. The BK tree helps reduce the number of of dictionary checks we have to do by about 90%.