Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add follow-up assert during unwinding #112817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kunalspathak
Copy link
Member

follow-up to #112799 (comment)

@Copilot Copilot bot review requested due to automatic review settings February 22, 2025 14:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/jit/unwindamd64.cpp: Language not supported
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 22, 2025
@kunalspathak
Copy link
Member Author

Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

code->OpInfo = (BYTE)(genIsValidFloatReg(reg) ? reg - XMMBASE : reg);
if (genIsValidFloatReg(reg))
{
code->OpInfo = reg - XMMBASE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @BruceForstall was also suggesting we validate that it's within the expected range to cover future expansions we might have

So we currently have up to 32 for both float and integer registers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking something like:

        unsigned unwindRegNum;
        if (genIsValidFloatReg(reg))
        {
            unwindRegNum = reg - XMMBASE;
        }
        else
        {
            assert(genIsValidIntReg(reg));
            unwindRegNum = reg;
        }
        assert(unwindRegNum <= 15);
        code->OpInfo = (UCHAR)unwindRegNum;
        assert((unsigned)code->OpInfo == unwindRegNum); // check that it fit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants