Add ability to match exact agent/service name #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new -x option to match exactly * mods to grep and with_match usages to use an exact pattern if -x is set on the command line * fixed issue in `with_match` which was not sending the 'no daemon' message (if instead of unless) Without this fix, on a system with homebrew's elasticsearch and elasticsearch14, you can't `lunchy uninstall` or `lunchy start` because `homebrew.mxcl.elasticsearch` is a match for both. After this you can `lunchy stop -x homebrew.mxcl.elasticsearch`
|
I'd love this feature. |
eddiezane
added a commit
that referenced
this pull request
May 2, 2015
Add ability to match exact agent/service name
|
Great idea! Thanks for the PR. |
|
thanks for the merge. On Fri, May 1, 2015 at 8:51 PM, Eddie Zaneski [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_matchwhich was not sending the 'no daemon' message (if instead of unless)Without this fix, on a system with homebrew's elasticsearch and elasticsearch14,
you can't
lunchy uninstallorlunchy startbecausehomebrew.mxcl.elasticsearchisa match for both.
After this you can
lunchy stop -x homebrew.mxcl.elasticsearchNote: I left VERSION alone, though I think it'll need a bump before a release.