Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist Topic Tree Data #1778

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Persist Topic Tree Data #1778

merged 8 commits into from
Oct 22, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Oct 18, 2024 •
edited
Loading

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #1244

What is the new behavior?

  1. Modify the tree data format.
  2. Update the message queue.
  3. Obtain updatedNodes for subsequent data updates.
  4. Update test cases.
  5. Tree Data supports local persistent storage of data.
  6. Support clearing Tree Data.
image image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added refactor Refactor code or architecture desktop MQTTX Desktop test labels Oct 18, 2024
@ysfscream ysfscream requested a review from Red-Asuka October 18, 2024 02:43
@ysfscream ysfscream self-assigned this Oct 18, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Oct 18, 2024
@ysfscream ysfscream marked this pull request as ready for review October 18, 2024 02:53
@ysfscream ysfscream marked this pull request as draft October 18, 2024 05:11
@ysfscream ysfscream marked this pull request as ready for review October 18, 2024 14:59
@ysfscream ysfscream changed the title refactor(desktop): update save message methods on topic tree Persist Topic Tree Data Oct 18, 2024
@ysfscream ysfscream added the migration database migration label Oct 18, 2024
@ysfscream ysfscream added the feature This pr is a feature label Oct 18, 2024
@ysfscream ysfscream requested a review from LAST7 October 18, 2024 15:40
ysfscream
ysfscream commented Oct 21, 2024
View reviewed changes
src/components/charts/Tree.vue
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is currently a work in progress; please disregard it now and focus on the storage implementation. I need to synchronize the code, so I submitted the code that is in progress.

@Red-Asuka Red-Asuka merged commit 3b2098a into main Oct 22, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch October 22, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-Asuka Red-Asuka Red-Asuka approved these changes

@LAST7 LAST7 Awaiting requested review from LAST7

Assignees

@ysfscream ysfscream

Labels
desktop MQTTX Desktop feature This pr is a feature migration database migration refactor Refactor code or architecture test
Projects
MQTTX
Status: Done
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ysfscream @Red-Asuka