Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better selection handler for Date & Time Picker #835

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

enisn
Copy link
Owner

@enisn enisn commented Dec 12, 2024

Refers to #804

After that PR, there was an infinity loop on windows and it was impossible to use.

This PR applies a simplier way for the same logic and I'll implement a better datepicker with a good nullability support unlike this workaround.

@enisn enisn merged commit cbf33a6 into develop Dec 12, 2024
2 checks passed
@enisn enisn deleted the date-time-picker branch December 12, 2024 18:36
@StepKie
Copy link
Contributor

StepKie commented Dec 17, 2024

@enisn Unfortunately, this does not work in production.

Can be checked in UraniumUI on the DatePickerField page.

It 100% worked with #804.

@enisn
Copy link
Owner Author

enisn commented Dec 17, 2024

Sorry for reverting that but when Two Way Binding is used, the code was entering infinity loop, so I needed to revert.

I'll probably go with custom implementation for DatePicker instead using built-in MAUI datepicker soon


BTW this PR seems solves problems with TimePicker. Only DateTimePicker has some problems

@StepKie
Copy link
Contributor

StepKie commented Dec 17, 2024

BTW this PR seems solves problems with TimePicker. Only DateTimePicker has some problems

@enisn I noticed that, but I saw that there is different implementation in your MR, so I was not surprised.

But it still doesn't work fully (for example, you can't select the default time after loading (12 AM, open picker, click ok)
it only works after first selecting something, and then clearing it. then it starts working as expected. Which will not fix the most important use case (initialize a TimePicker with null)

@StepKie
Copy link
Contributor

StepKie commented Dec 18, 2024

I'll probably go with custom implementation for DatePicker instead using built-in MAUI datepicker soon

@enisn but what is "soon"? this sounds like a non-trivial amount of work, and I had submitted my PR since this was really important to us in our production app.

@enisn
Copy link
Owner Author

enisn commented Dec 19, 2024

I made some progress but android blocks me. There is no date multiple selection in android calendar by default. Probably I'll skip multiple selection at the first implementation

@ketakidevendra
Copy link

@enisn - Any update on this? We need this in our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants