-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: namespace quota #13516
*: namespace quota #13516
Conversation
0da3f52
to
6ceb2b0
Compare
@wenjiaswe @ptabor @serathius @wojtek-t @hexfusion @jingyih 3.4 - https://github.com/etcd-io/etcd/pull/13486/files (we had initially started developing on 3.4) Technical document: https://docs.google.com/document/d/1POdNdFBgpcGqLwurZjy8qQki6beOoVIcElTqHy4DnnA/edit |
Thx for your work! But I'm wondering that this big change is hard to review, so any splitting would be helpful 😢. |
@JmPotato Hi sure, let me logically chunk them out, thank you. I will update you once I break them apart. |
6ceb2b0
to
1d1f667
Compare
0fc4dba
to
6d6f59d
Compare
Codecov Report
@@ Coverage Diff @@
## main #13516 +/- ##
==========================================
- Coverage 75.11% 74.01% -1.10%
==========================================
Files 448 458 +10
Lines 37181 37909 +728
==========================================
+ Hits 27929 28059 +130
- Misses 7484 8022 +538
- Partials 1768 1828 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3fde36d
to
71a0489
Compare
@JmPotato @wenjiaswe @ptabor @serathius @wojtek-t @hexfusion @jingyih rebased the PR, bumping again. Sorry it took so long. I've tried to breakdown the PR into more logical components so that it builds up in the following fashion:
Please feel free to reach out with any questions, feedback is welcome. Thank you. |
71a0489
to
8734c7c
Compare
1643634
to
bb39cec
Compare
As discussed in meeting on June 2, 2022, this will be reviewed at a later time, potentially 3.7.x/3.8.x. |
To add functionality surroundind the namespace quotas.
Ability to set, delete, list, and get quotas.
Framework to interact with core etcd ops.
This PR is against master, a related PR against branch-3.4 is made here: #13486
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.