-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.6] *: support DowngradeInfo field in maintenence.Status API #19460
base: release-3.6
Are you sure you want to change the base?
[release-3.6] *: support DowngradeInfo field in maintenence.Status API #19460
Conversation
Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Wei Fu <[email protected]>
1. Update DowngradeUpgradeMembersByID If it's downgrading process, the desire version of cluster should be target one. If it's upgrading process, the desire version of cluster should be determined by mininum binary version of members. 2. Remove AssertProcessLogs from DowngradeEnable The log message "The server is ready to downgrade" appears only when the storage version monitor detects a mismatch between the cluster and storage versions. If traffic is insufficient to trigger a commit or if an auto-commit occurs right after reading the storage version, the monitor may fail to update it, leading to errors like: ```bash "msg":"failed to update storage version","cluster-version":"3.6.0", "error":"cannot detect storage schema version: missing confstate information" ``` Given this, we should remove the AssertProcessLogs statement. Similar to etcd-io#19313 Signed-off-by: Wei Fu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@fuweid Could you please update the 3.6 changelog as well? |
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #19460 +/- ##
===============================================
- Coverage 68.99% 68.90% -0.10%
===============================================
Files 420 420
Lines 35753 35762 +9
===============================================
- Hits 24669 24642 -27
- Misses 9662 9693 +31
- Partials 1422 1427 +5 Continue to review full report in Codecov by Sentry.
|
After upgrading the member to 3.6, saw lots of the following error message. It seems that it's a test bug. The server returned the corrected version, but the test case was expecting a wrong cluster version (3.5.0). cc @fuweid
|
@ahrtr it's test issue related to DowngradeUpgradeMembersByID change. File pull request later |
The following code snip should have issue. etcd/tests/framework/e2e/downgrade.go Lines 165 to 168 in ac7d3e9
The implementation should be something like below,
|
OK, please raise the PR on main. After merging that PR, can you please manually backport both PRs to release-3.6? |
Yes. will do |
This is an automated cherry-pick of #19451
/assign ahrtr