scripts/updatebom: remove innecessary mod override #19467
Conversation
The `GOFLAGS=-mod=mod` environment variable is not required, as that's the default mode. This code was likely copied from the tests, where `GOFLAGS` is set to `-mod=readonly`. So, executing the tool needs to override `mod`, as per the documentation, it tends to modify the `go.mod` file. Signed-off-by: Ivan Valdes <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ivanvc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #19467 +/- ##
==========================================
+ Coverage 68.85% 68.98% +0.12%
==========================================
Files 420 420
Lines 35762 35762
==========================================
+ Hits 24624 24670 +46
+ Misses 9714 9674 -40
+ Partials 1424 1418 -6 Continue to review full report in Codecov by Sentry.
|
The
GOFLAGS=-mod=modenvironment variable is not required, as that's the default mode. This code was likely copied from the tests, whereGOFLAGSis set to-mod=readonly. So, executing the tool needs to overridemod, as per the documentation, it tends to modify thego.modfile.Spun off from: #19423.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.