Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gopkg.toml: remove unnecessary constraints and add pruning #9258

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Gopkg.toml: remove unnecessary constraints and add pruning #9258

merged 1 commit into from
Jan 31, 2018

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jan 31, 2018

Confirmed that dep ensure results in no version changes in Gopkg.lock.

@gyuho

Confirmed that `dep ensure` results in no version changes in Gopkg.lock.
@codecov-io
Copy link

Codecov Report

Merging #9258 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9258      +/-   ##
==========================================
+ Coverage   75.74%   75.87%   +0.12%     
==========================================
  Files         363      363              
  Lines       30200    30200              
==========================================
+ Hits        22876    22914      +38     
+ Misses       5718     5683      -35     
+ Partials     1606     1603       -3
Impacted Files Coverage Δ
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
clientv3/watch.go 95.83% <0%> (-0.74%) ⬇️
clientv3/leasing/kv.go 89.7% <0%> (-0.67%) ⬇️
clientv3/health_balancer.go 85.67% <0%> (-0.31%) ⬇️
etcdserver/v3_server.go 81.65% <0%> (+0.25%) ⬆️
etcdserver/server.go 79.51% <0%> (+0.34%) ⬆️
pkg/netutil/netutil.go 68.75% <0%> (+1.04%) ⬆️
internal/lease/leasehttp/http.go 65.44% <0%> (+1.47%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9deeff...42344da. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

/cc @fanminshi and #9224

@gyuho gyuho merged commit 610aefb into etcd-io:master Jan 31, 2018
@tamird tamird deleted the dep-cleanup branch January 31, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants