Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers: fix state hooks in API #30830

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Nov 28, 2024

When a tx/block was being traced through the API the state hooks weren't being called as they should. This is due to #30745 moving the hooked statedb one level up in the state processor. This PR fixes that.

@s1na
Copy link
Contributor Author

s1na commented Nov 29, 2024

@rjl493456442 @holiman PTAL

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sorry for breaking the tracer hooks.

@holiman holiman added this to the 1.14.13 milestone Nov 29, 2024
@holiman holiman merged commit ce8cec0 into ethereum:master Nov 29, 2024
2 of 3 checks passed
@fjl fjl modified the milestones: 1.14.13, 1.15.0 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants