Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): remove some unused jobs and remove some falco-builder reference where possible #2322

Merged
merged 2 commits into from
Dec 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -194,37 +194,40 @@ jobs:
- run:
name: Execute driver-loader integration tests
command: /tmp/ws/source/falco/test/driver-loader/run_test.sh /tmp/ws/build/release/

# Code quality
"quality-static-analysis":
docker:
- image: falcosecurity/falco-builder:latest
environment:
BUILD_TYPE: "release"
machine:
enabled: true
image: ubuntu-2204:2022.10.2
steps:

- run:
name: Install cppcheck
name: Install deps ⛓️
command: |
yum update -y
yum install epel-release -y
yum install cppcheck cppcheck-htmlreport -y
sudo apt update -y
sudo apt install build-essential git cppcheck cmake -y

- checkout:
path: /source/falco
- run:
name: Prepare project
command: /usr/bin/entrypoint cmake
- run:
name: cppcheck
command: /usr/bin/entrypoint cppcheck
path: /tmp/source/falco

# We can use `USE_BUNDLED_DEPS=On` since the build is very fast
- run:
name: cppcheck html report
command: /usr/bin/entrypoint cppcheck_htmlreport
name: Build and run cppcheck
command: |
mkdir -p /tmp/source/falco/build
cd /tmp/source/falco/build && cmake -DUSE_BUNDLED_DEPS=On -DBUILD_WARNINGS_AS_ERRORS=ON -DCREATE_TEST_TARGETS=Off -DCMAKE_BUILD_TYPE="release" -DBUILD_BPF=Off -DBUILD_DRIVER=Off ..
make -j4 cppcheck
make -j4 cppcheck_htmlreport

- store_artifacts:
path: /build/release/static-analysis-reports
path: /tmp/source/falco/build/static-analysis-reports
destination: /static-analysis-reports

# Sign rpm packages
"rpm-sign":
docker:
- image: falcosecurity/falco-builder:latest
- image: docker.io/centos:7
steps:
- attach_workspace:
at: /
Expand Down Expand Up @@ -265,6 +268,7 @@ jobs:
paths:
- build/release/*.rpm
- build-arm64/release/*.rpm

# Publish the dev packages
"publish-packages-dev":
docker:
Expand Down
65 changes: 0 additions & 65 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,68 +108,3 @@ jobs:
pushd build
make tests
popd

build-ubuntu-bionic:
runs-on: ubuntu-18.04
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}

- name: Update base image
run: sudo apt update -y

- name: Install build dependencies
run: sudo DEBIAN_FRONTEND=noninteractive apt install cmake build-essential clang llvm git linux-headers-$(uname -r) pkg-config autoconf libtool libelf-dev -y

- name: Prepare project
run: |
mkdir build
pushd build
cmake -DBUILD_BPF=On -DUSE_BUNDLED_DEPS=On ..
popd

- name: Build
run: |
pushd build
KERNELDIR=/lib/modules/$(uname -r)/build make -j4 all
popd

- name: Run unit tests
run: |
pushd build
make tests
popd

build-centos7-debug:
runs-on: ubuntu-latest
container:
image: falcosecurity/falco-builder:latest
env:
BUILD_TYPE: "debug"
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
path: falco
ref: ${{ github.event.pull_request.head.sha }}

- name: Link falco repo to /source/falco
run: |
mkdir -p /source
ln -s "$GITHUB_WORKSPACE/falco" /source/falco

- name: Prepare project
run: /usr/bin/entrypoint cmake

- name: Build
run: /usr/bin/entrypoint all

- name: Run unit tests
run: /usr/bin/entrypoint tests

- name: Build packages
run: /usr/bin/entrypoint package