Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(build): prune deb-dev and rpm-dev directories #3056

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

What this PR does / why we need it:

This PR limits the total amount of deb-dev and rpm-dev packages to 10GB. This is because in order to be updated we need to download all packages, check metadata and sync them with the bucket. GHA runners have less than 20GB space and they take time to download data. This retention seems reasonable.

Which issue(s) this PR fixes:

Fixes #2862

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@@ -121,6 +121,47 @@ update_repo() {
popd > /dev/null
}

reduce_dir_size() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the reviewer: you might notice that this function is duplicated in two files. I actually wanted to add it to a different file that could be sourced relatively to this script but it appears that this cannot be done reliably in Bash because it depends on where the script is located and would make it unportable. Rather than figuring out Bash I thought about just copy pasting it

@FedeDP
Copy link
Contributor

FedeDP commented Feb 7, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Feb 7, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 7, 2024

LGTM label has been added.

Git tree hash: 8489942716cdc2addac2694b725371801d18d5ae

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b091522 into falcosecurity:master Feb 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

S3 packages/deb-dev and rpm-dev has surpassed 20GB, the GHA worker will not download it
4 participants