-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(build): prune deb-dev and rpm-dev directories #3056
new(build): prune deb-dev and rpm-dev directories #3056
Conversation
Signed-off-by: Luca Guerra <[email protected]>
@@ -121,6 +121,47 @@ update_repo() { | |||
popd > /dev/null | |||
} | |||
|
|||
reduce_dir_size() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for the reviewer: you might notice that this function is duplicated in two files. I actually wanted to add it to a different file that could be sourced relatively to this script but it appears that this cannot be done reliably in Bash because it depends on where the script is located and would make it unportable. Rather than figuring out Bash I thought about just copy pasting it
/milestone 0.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 8489942716cdc2addac2694b725371801d18d5ae
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Given the logs ( https://pipelinesghubeus23.actions.githubusercontent.com/pJJfkAWThFToHyEBhjXnwK2xzHmpIeKwCAG6QbCTGWgtm8nup8/_apis/pipelines/1/runs/16142/signedlogcontent/143?urlExpires=2024-02-07T17%3A09%3A35.9511405Z&urlSigningMethod=HMACV1&urlSignature=dnUL5ilKwWjWMDqVo9kkwEIhAZ8DrWSwGfMF1cBkHmY%3D ), I think I have messed up the |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
This PR limits the total amount of
deb-dev
andrpm-dev
packages to 10GB. This is because in order to be updated we need to download all packages, check metadata and sync them with the bucket. GHA runners have less than 20GB space and they take time to download data. This retention seems reasonable.Which issue(s) this PR fixes:
Fixes #2862
Special notes for your reviewer:
Does this PR introduce a user-facing change?: