add a print_line rhai script helper #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
approved these changes
May 21, 2023
src/rhai_engine.rs
Outdated
| @@ -6,12 +6,19 @@ pub fn custom_rhai_engine_init() -> Engine { | |||
| let mut rhai_engine = Engine::new(); | |||
|
|
|||
| rhai_engine.register_fn("current_date", current_date); | |||
| rhai_engine.register_fn("print_line", print_line); | |||
There was a problem hiding this comment.
Given the usage I wonder if some wording involving log / debug / console might clarify that this goes to the console rather than to the page itself. My first thought was log_debug but that might be too prescriptive - log_console or console_println maybe?
There was a problem hiding this comment.
I like the console_println name. I'll update the PR.
karthik2804
force-pushed
the
rhai_helper/print_line
branch
from
6e17ca3 to
5e3462d
Compare
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
rhai_helper/print_line
branch
from
5e3462d to
d7ff7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.