broken links

[rajatjindal]

in spin/* pages, the link to other pages under spin is currently broken. e.g.

• go to http://localhost:3000/spin/index
• scroll to the end
• click on take Spin for a spin
• observe the link is broken

noticed that its broken similarly in other pages as well.

[rajatjindal]

it might be related to how bartholomew handles relative links.

[rajatjindal]

opened PR: fermyon/bartholomew#136 which hopefully fixes this issue

[rajatjindal]

after the fix:

blc --recursive http://127.0.0.1:3000 --exclude-external 
Getting links from: http://127.0.0.1:3000/
├───OK─── http://127.0.0.1:3000/spin
├───OK─── http://127.0.0.1:3000/cloud
Finished! 24 links found. 22 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin
└───OK─── http://127.0.0.1:3000/spin/quickstart
Finished! 42 links found. 41 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/cloud
Finished! 47 links found. 47 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/quickstart
├───OK─── http://127.0.0.1:3000/spin/contributing
├───OK─── http://127.0.0.1:3000/spin/configuration
├───OK─── http://127.0.0.1:3000/spin/rust-components
├───OK─── http://127.0.0.1:3000/spin/go-components
├───OK─── http://127.0.0.1:3000/spin/developing
Finished! 56 links found. 51 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/contributing
└───OK─── http://127.0.0.1:3000/spin/extending-and-embedding
Finished! 53 links found. 52 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/configuration
├───OK─── http://127.0.0.1:3000/spin/http-trigger
└───OK─── http://127.0.0.1:3000/spin/redis-trigger
Finished! 53 links found. 51 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/rust-components
Finished! 53 links found. 53 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/go-components
Finished! 52 links found. 52 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/developing
Finished! 41 links found. 41 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/extending-and-embedding
Finished! 54 links found. 54 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/http-trigger
├───OK─── http://127.0.0.1:3000/spin/distributing-apps
Finished! 57 links found. 56 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/redis-trigger
Finished! 51 links found. 51 excluded. 0 broken.

Getting links from: http://127.0.0.1:3000/spin/distributing-apps
Finished! 46 links found. 46 excluded. 0 broken.

Finished! 629 links found. 617 excluded. 0 broken.
Elapsed time: 1 second

we should add broken checks as github action as well.

[rajatjindal]

we also probably need to fix sidebar nav from:

<li><a href="{{site.info.base_url}}/spin/other-languages/">Other languages</a></li>

to

<li><a href="{{site.info.base_url}}/spin/other-languages">Other languages</a></li>

Notice the / missing after other-languages

[rajatjindal]

the bartholomew PR is merged, we should pull in new wasm for it

[karthik2804]

closed with #53