-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix relative link parsing #136
Conversation
|
f8fa1a0
to
fe916ca
Compare
Signed-off-by: Rajat Jindal <[email protected]>
fe916ca
to
805cf14
Compare
I will test more tomorrow to ensure it does not break anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It's possible this might break links that were implicitly absolute, but we should be able to fix those on a case-by-case basis.
Thanks for looking at the pr. Could u pls give an example of the link you are referring to. I will add that to the testcase and verify that it works. Many thanks |
For example, imagine you have a couple of documents like this: foo/bar/baz.md And imagine foo/bar/baz.md has a link like |
thanks for the explanation @dicej . yeah I would also consider that as bad link and that should be fixed in the content itself |
still testing the changes out, for some reason unable to run
make test
on my laptop.