No tax info for bundle products - intentionally?

[infabo]

In class FireGento_MageSetup_Block_Bundle_Catalog_Product_Price the following method does return an empty tax-rate if the product type is of type "bundle".
Is this by design or should it rather be "grouped"? By Magento default bundle-products do have a tax_class_id, therefore it should be possible (IMHO) to calculate the tax_rate for bundles.
I'm a bit confused.

https://github.com/firegento/firegento-magesetup/blob/master/src/app/code/community/FireGento/MageSetup/Block/Bundle/Catalog/Product/Price.php#L79

 /**
     * Retrieves formatted string of tax rate for user output
     *
     * @return string Formatted Tax Rate for the given locale
     */
    public function getFormattedTaxRate()
    {
        if ($this->getTaxRate() === null
            || $this->getProduct()->getTypeId() == 'bundle'
        ) {
            return '';
        }

        $locale = Mage::app()->getLocale()->getLocaleCode();
        $taxRate = Zend_Locale_Format::toFloat($this->getTaxRate(), array('locale' => $locale));

        return $this->__('%s%%', $taxRate);
    }

Could someone enlighten me? :)

[luckyduck]

I can confirm that the tax info is missing for bundled products. Simply modifying the if-statement doesn't help, though.

[Schrank]

What is the tax class for bundle products with mixed taxes?

[infabo]

Good question. At least a bundle product with a fixed price should have a tax class.

[Detzler]

It doesn't matter what kind of articles are inside the bundle product. It's just a backend question.
From the frontend (buyers) point of view, the bundle product is just a "simple product" that contains stuff.
The merchant is responsible to mark this product with the right tax class.
MageSetup shouldn't deliver any automatism for the tax classes of bundle products.

[Detzler]

@infabo Did you find out how to enable the block on bundle product pages?

[Schrank]

Unfortunately not. You cannot configure a tax class for a product:

It is just greyed out.

[Schrank]

So the tax class is the one from the simple items - which might have different ones. In Germany this can be 0%, 7% and 19% which is horrible. It is the same horrible as for shipping.

[infabo]

ok. seems like it's time for a PR ;)

[Schrank]

Maybe I'm too dumb, but how to configure a fixed tax class on a bundle product?

[Detzler]

If the price is set to be fixed (selectbox near price attribute) then the tax class is applicable in the backend. So MageSetup should show the block as like as at the simple product.

Otherwise it's dynamic. That's what @Schrank means.
How to show the block then?

This law office says that it's not required to print the exact amount of the tax at the german market.
It's just enough to say "inkl MwSt".
https://www.it-recht-kanzlei.de/Thema/preisangabenverordnung.html?page=2#sect_4

[Schrank]

Be careful. What they say is IF (and only if) there is no add to cart button, THEN we don't have to print anything.

[sprankhub]

My latest commit ensures that the tax rate is shown for bundle products with fixed pricing.

We could at least improve the tax rate display for bundle products with dynamic pricing like this:

1. If all associated child products have the same tax rate, show this tax rate.
2. If they have different tax rates, do not show any exact tax rate.

We should just be careful that the retrieval of the child products is performant.

[Schrank]

I'll open a new issue for the dynamic bundles to keep it cleaner.